Drop the requirement for dist-git-merge in discover/fmf#4915
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes the requirement for the --dist-git-merge option when working with dist-git sources in the discover step. It removes the validation check in tmt/steps/discover/fmf.py and updates the integration tests in tests/discover/distgit.sh to reflect this change. I have no feedback to provide.
LecrisUT
added
ci | full test
thrix
left a comment
thrix
left a comment
There was a problem hiding this comment.
LGTM.
Because this is in changing a user facing interface, would deserve a release note in my POW.
I considered that initially, but it was never documented that there was such a restriction. |
|
@LecrisUT relevant tests are failing. |
Oh, thank you for the ping, checking it now |
Signed-off-by: Cristian Le <git@lecris.dev>
Signed-off-by: Cristian Le <git@lecris.dev>
Signed-off-by: Cristian Le <git@lecris.dev>
Signed-off-by: Cristian Le <git@lecris.dev>
|
/packit retest-failed |
3 participants
Pull Request Checklist
Closes #4840